feat(dogs): add color lookup support#261
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Add dog color storage, legacy import mapping, public profile display, and admin form color selection backed by lookup data. Files: - CHANGELOG.md - apps/web/app/actions/admin/dogs/lookups/get-admin-dog-color-options.ts - apps/web/components/admin/dogs/admin-dogs-page-client.tsx - apps/web/components/admin/dogs/dog-form-modal.tsx - apps/web/components/admin/dogs/internal/dog-form-metadata-section.tsx - apps/web/components/beagle-dog-profile/dog-profile-details-card.tsx - apps/web/lib/admin/dogs/manage/dog-form-mappers.ts - apps/web/lib/admin/dogs/manage/dog-mutation-flow.ts - apps/web/queries/admin/dogs/lookups/use-admin-dog-color-options-query.ts - docs/features/admin-dog-management.md - docs/features/beagle-dog-profile.md - docs/features/schema/schema.md - docs/legacy-import/phase1.md - packages/contracts/admin/dogs/lookups/lookup-options.ts - packages/contracts/admin/dogs/manage/admin-dogs-list.ts - packages/contracts/admin/dogs/manage/create-admin-dog.ts - packages/contracts/admin/dogs/manage/update-admin-dog.ts - packages/db/admin/dogs/lookups/list-color-options.ts - packages/db/prisma/migrations/20260506120000_add_dog_colors/migration.sql - packages/db/prisma/schema.prisma - packages/server/admin/dogs/lookups/list-color-options.ts - packages/server/admin/dogs/manage/create-dog.ts - packages/server/admin/dogs/manage/update-dog.ts - packages/server/imports/phase1/run-legacy-phase1.ts - related tests and index exports ref bej-107
- cover the admin dog color lookup service, action wrapper, and query hook - verify auth, success, and failure branches so the coverage gate passes ref bej-107
asku1990
force-pushed
the
feature/bej-107-import-dog-color-details
branch
from
464dc59 to
b29634a
Compare
Seed and expose a canonical dog color catalog with status metadata, use it for admin selection and profile display, and preserve legacy hidden colors during updates and phase 1 import. ref bej-107
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Reply with Previous Review Summaries (2 snapshots, latest commit ddc1b7f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ddc1b7f)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Reply with Previous review (commit 3c6a8d2)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Reply with Reviewed by step-3.7-flash-20260528 · Input: 268.3K · Output: 17.7K · Cached: 790.8K |
Replace the React Query Server Action path with a canonical admin API route, keep the server use case as the source of business logic, and remove the now- unused color lookup action. Files: - apps/web/app/actions/admin/dogs/lookups/__tests__/get-admin-dog-color-options.test.ts - apps/web/app/actions/admin/dogs/lookups/get-admin-dog-color-options.ts - apps/web/app/api/admin/dogs/lookups/colors/__tests__/route.test.ts - apps/web/app/api/admin/dogs/lookups/colors/route.ts - apps/web/queries/admin/dogs/lookups/__tests__/use-admin-dog-color-options-query.test.ts - apps/web/queries/admin/dogs/lookups/use-admin-dog-color-options-query.ts - packages/api-client/admin/dogs/__tests__/admin-dogs.test.ts - packages/api-client/admin/dogs/create-admin-dogs-api-client.ts - packages/api-client/admin/dogs/index.ts - packages/api-client/admin/dogs/list-admin-dog-color-options.ts ref bej-107
ref bej-107
Owner
Author
Manual Testing ChecklistDatabase & Import
Admin - Create Dog
Admin - Edit Dog
Hidden Color Preservation
Legacy Unknown Preservation
Validation & Security
Public Profile
Regression Testing
Quality Checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
ref bej-107